[PATCH] ath10k: fix potential null dereference bugs

Johannes Berg johannes at sipsolutions.net
Mon Jun 13 02:08:59 PDT 2016


On Mon, 2016-06-13 at 07:39 +0200, Michal Kazior wrote:
> 
> FWIW all of these are false positives. I think this was already
> pointed out some time ago. The drv_priv stuff is merely an offset
> (see how ieee80211_vif and ieee80211_sta are defined) and the
> according structure is always checked beforehand.
> 

IIRC, doing something like that can (sometimes?) still get you into
undefined behaviour territory, so the compiler could potentially
"optimize" away the later NULL check.

Or am I confusing something? Seems entirely possible :)

johannes



More information about the ath10k mailing list