[PATCH] tree-wide: replace config_enabled() with IS_ENABLED()

Kees Cook keescook at chromium.org
Mon Jun 6 08:53:29 PDT 2016


On Mon, Jun 6, 2016 at 5:20 AM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> The use of config_enabled() against config options is ambiguous.
> In practical terms, config_enabled() is equivalent to IS_BUILTIN(),
> but the author might have used it for the meaning of IS_ENABLED().
> Using IS_ENABLED(), IS_BUILTIN(), IS_MODULE() etc. makes the
> intention clearer.
>
> This commit replaces config_enabled() with IS_ENABLED() where
> possible.  This commit is only touching bool config options.
>
> I noticed two cases where config_enabled() is used against a tristate
> option:
>
>  - config_enabled(CONFIG_HWMON)
>   [ drivers/net/wireless/ath/ath10k/thermal.c ]
>
>  - config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)
>   [ drivers/gpu/drm/gma500/opregion.c ]
>
> I did not touch them because they should be converted to IS_BUILTIN()
> in order to keep the logic, but I was not sure it was the authors'
> intention.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Sounds good to me! :)

Acked-by: Kees Cook <keescook at chromium.org>

-- 
Kees Cook
Chrome OS & Brillo Security



More information about the ath10k mailing list