Question on "ath10k: document ofdm/5ghz rate offset with a macro"

[Ben Greear]

On 06/07/2016 06:16 AM, Michal Kazior wrote:
> On 7 June 2016 at 14:57, Ben Greear <greearb at candelatech.com> wrote:
>> On 06/06/2016 11:23 PM, Michal Kazior wrote:
>>> On 6 June 2016 at 23:25, Ben Greear <greearb at candelatech.com> wrote:
>>>>
>>>> While porting some patches forward, I notice the change below
>>>> that renamed the method to "ath10k_mac_sta_has_ofdm_only".  But,
>>>> that is not really what that is checking, since it just throws
>>>> away the CCK rates (and they might have been there).
>>>>
>>>> Maybe it should just be "ath10k_mac_sta_has_ofdm()" ?
>>>
>>> Yes, this seems like an unfortunate name pick on my side. The MODE_11G
>>> phymode is for mixed b/g.
>>
>> I think the actual code behaviour is right.  I have some patches to
>> support G-only mode and such, and will change the name of your method
>> in those patches to be more clear.
>>
>> Lots of other pending patches of mine before I will get to trying to push
>> that one upstream though.
>
> Hmm.. I do recall 11G_ONLY phymode didn't play out well with 11B
> coexistance in AP mode. I can't remember the details though..

If you remember a test case for this, let me know.

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com