[PATCH 2/2] ath10k: remove 10.1 firmware support

Ben Greear greearb at candelatech.com
Fri Jun 3 09:46:56 PDT 2016


On 06/03/2016 09:33 AM, Valo, Kalle wrote:
> Ben Greear <greearb at candelatech.com> writes:
>
>>>> Is it possible to upgrade CT firmware to 10.2 WMI/HTT interfaces?
>>>
>>> That's a good idea. That shouldn't be too hard, right? I don't think HTT needs
>>> any changes, but for WMI few commands and ids need to be changed.
>>
>> I was thinking the 10.2 mgt-over-htt API would be trouble-some to make work on
>> 10.1 firmware.
>
> Yeah, that would be harder. But I don't see Rajkumar removing support
> for that (yet) or am I missing something?

What I mean is that to just make my 10.1 firmware act like 10.2 would require
my 10.1 to suddenly support 10.2's mgt-over-htt.  I think that will be difficult,
and there is plenty of risk that some subtle WMI change would cause hard-to-detect
bugs.

I have done an initial port of my 10.1 changes to 10.2, it is just that the
result is poor, and so I quit messing with 10.2 and re-focussed on 10.1
for the time being.

Another way to help with this problem in general is to quit adding so many
new firmware API.  It is a lot easier to make a new firmware backwards compat
than it is to make an old firmware forwards compat.  When you are designing your
WMI changes in new firmware, do it with care, and then you can reuse the vast bulk
of your driver.  I managed to add quite a few new features to my 10.1 in this
manner, and the driver patches (mostly keyed off of feature flags) are not that
invasive.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com




More information about the ath10k mailing list