[PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later
Mohammed Shafi Shajakhan
mohammed at codeaurora.org
Wed Jul 20 09:27:51 PDT 2016
On Wed, Jul 20, 2016 at 02:22:29PM +0200, Michal Kazior wrote:
> On 20 July 2016 at 13:43, Shajakhan, Mohammed Shafi (Mohammed Shafi)
> <mohammed at qti.qualcomm.com> wrote:
> > Michal,
> > Can you please let me know if this change is fine or not ?
> > I am waiting infinitely for your reply long time
> Sorry. I was absent for a while and this email slipped by.
[shafi] ah ok, i thought you had blacklisted this change :)
> Quoting your other email:
> > is this patch is good to go (or) should i re-work ?
> > I had replied to Michal's comment of introducing a new firmware
> > feature flag will not address the issue in older firmware / code.
> > Let me know if i had missed something very obvious.
> I couldn't really find any conclusion to this thread in my inbox.
> The hw_params approach is definitely wrong. The ACK problem is
> firmware-specific, not hardware-specific.
[shafi] sure let me see if i can figure out an alternative way that shall be
accepted by you and Kalle
> I'm fine with removing the workaround completely if 636 is guaranteed
> to not be broken, including AP and P2P GO operation. The client
> operation will probably work since wmi-roam event is used for HW
> connection monitoring.
[shafi] sorry i am not sure how to validate that, so i will keep this workaround
> Nullfunc tx-status ack/noack reports could be probably fixed up using
> sta kickout events (with short timeouts) as a fallback. This would
> make it easier for users because otherwise they'd need to enable
> disassoc_low_ack in hostapd (which is probably impossible with
> wpa_supplicant for p2p, no?).
[shafi] let me check this, i think we usually don't enable disassoc_low_ack to
avoid kicking out stations frequently.
More information about the ath10k