[PATCHv3 0/2] ath10k: Allow setting coverage class

Benjamin Berg benjamin at sipsolutions.net
Thu Aug 25 06:25:20 PDT 2016


This revision of the patch has quite a number of changes, most notably the
handler to set the registers is now called from a work queue after a WMI

The reason for this is that Sebastian reported that at least the WAVE2
chipsets do not behave well when the calls happen before the hardware is
initialized. This means we need to check ar->state, which in turn is
protected by conf_mutex, so the task is now pushed to the general work
queue to prevent having to hold the lock during the WMI event processing.

Changes in v3:
 * Only update register values if hardware is initialized
 * Use the SM/MS macros instead of manual bitshifts and masks
 * Use the hardware phyclk register instead of assuming a clock speed
 * Force dbglog_mask of ~0 and dbglog_level of at least WARN if active
 * Only call code for selected WMI events

The last two items are a bit of a guess for me. In particular it looks like
the default log level is already WARN, but I suppose that this should be good
enough to get reports for internal chip resets. I have no way of verifying
this myself though.

Changes in v2 were:
 * Move code into hw.c and run from new hw_ops depending on chip revision
 * Error message corrections

The patch assumes that a new hw_ops struct exists based on work by
Vasanthakumar. The rename patch is on top of "ath10k: Add provision for
Rx descriptor abstraction" and adjustment in either patchset will be
neccessary for merging.
What are the plans with regard to getting those patches merged (ath10k:
Padding related clean ups in rx)?

Benjamin Berg (2):
  ath10k: Rename hw_rx_desc_ops to hw_ops to use it for other purposes
  ath10k: Allow setting coverage class

 drivers/net/wireless/ath/ath10k/core.c |  35 +++++---
 drivers/net/wireless/ath/ath10k/core.h |  12 +++
 drivers/net/wireless/ath/ath10k/hw.c   | 143 ++++++++++++++++++++++++++++++++-
 drivers/net/wireless/ath/ath10k/hw.h   |  36 +++++++--
 drivers/net/wireless/ath/ath10k/mac.c  |  19 +++++
 drivers/net/wireless/ath/ath10k/wmi.c  |  37 +++++++++
 6 files changed, 263 insertions(+), 19 deletions(-)


More information about the ath10k mailing list