master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core]

Manoharan, Rajkumar rmanohar at qti.qualcomm.com
Fri Aug 19 05:14:47 PDT 2016


[...]
>>
>> [  277.244673] ------------[ cut here ]------------
>> [  277.244685] WARNING: CPU: 2 PID: 2162 at lib/debugobjects.c:263 debug_print_object+0x85/0xa0
>> [  277.244707] ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core]
>
> I bisected this to:
>
> [v2] ath10k: implement NAPI support
>
> https://patchwork.kernel.org/patch/9240975/
> 
> I'll reply to that patch for more info.
> 
Oops.. my bad.. Sorry for the regression..Good that it is captured at earliest.
Thanks Kalle for reporting the issue.

It seems during deinit, driver is not waiting for NAPI completion. What debug options should be enabled to see this warning?
If possible, could you please try below change?

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 33380fba5948..29fc9052e51a 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1759,6 +1759,7 @@ void ath10k_pci_ce_deinit(struct ath10k *ar)

 void ath10k_pci_flush(struct ath10k *ar)
 {
+       napi_synchronize(&ar->napi);
        ath10k_pci_rx_retry_sync(ar);
        ath10k_pci_buffer_cleanup(ar);
 }

-Rajkumar


More information about the ath10k mailing list