[PATCH] ath10k: remove MSI range support
Rajkumar Manoharan
rmanohar at codeaurora.org
Tue Apr 5 06:36:25 PDT 2016
On 2016-04-05 18:21, Valo, Kalle wrote:
> Rajkumar Manoharan <rmanohar at qti.qualcomm.com> writes:
>
>> MSI-X is never well-tested, might contain bugs and generally isn't
>> really all that useful to maintain. Also ath10k is mainly used with
>> shared/singly-MSI interrupt systems. Hence removing MSI range support.
>> This change will be useful for further cleanup in copy engine lock
>> and to add NAPI support.
>>
>> Signed-off-by: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
>
> [...]
>
>> @@ -171,14 +168,10 @@ struct ath10k_pci {
>> void __iomem *mem;
>> size_t mem_len;
>>
>> - /*
>> - * Number of MSI interrupts granted, 0 --> using legacy PCI line
>> - * interrupts.
>> - */
>> - int num_msi_intrs;
>> + /* Operating interrupt mode */
>> + u8 oper_irq_mode;
>
> Shouldn't this be enum ath10k_pci_irq_mode?
Yes.. Then the enum should be moved to pci.h. will send next version
-Rajkumar
More information about the ath10k
mailing list