[PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

Arnd Bergmann arnd at arndb.de
Mon Sep 14 23:30:55 PDT 2015


On Tuesday 15 September 2015 07:34:38 Viresh Kumar wrote:
> On 14-09-15, 09:03, Greg KH wrote:
> > What ever ones you think it is relevant for :)
> 
> "Relevant" is a relevant term :)
> 
> So, the patch which defined the type bool as _Bool was added in v2.6.19 :)
> 
> 6e2182874324 ("[PATCH] Generic boolean")
> 
> So, I will try at least for v3.10+ as they are used by a lot of
> people, as they are LTS kernels. But wasn't sure if I should do it
> right from 2.6.19.

I don't think there is any use in backporting the global type change,
that is too invasive and does not change much. The specific bug
in the acpi code dates back to when acpi_ec_add_debugfs() was
added in 2.6.36, so that is the earliest point it could be backported
to. Then again, as I said it is only a problem on big-endian 64-bit
architectures, and on ACPI that would specifically mean arm64, which
only very recently gained ACPI support, so backporting to 4.1 is probably
enough.

	Arnd



More information about the ath10k mailing list