Question on ar->max_num_vdevs and WMI ops config.

Ben Greear greearb at
Mon Mar 30 14:09:57 PDT 2015

I'm porting forward my changes to the 4.0-rc6 kernel, and I notice
something a bit confusing to me.

It seems some upstream patch has added ar->max_num_vdevs and some related

But, in places like this:

static struct sk_buff *ath10k_wmi_op_gen_init(struct ath10k *ar)
	struct wmi_init_cmd *cmd;
	struct sk_buff *buf;
	struct wmi_resource_config config = {};
	u32 len, val;

	config.num_vdevs = __cpu_to_le32(TARGET_NUM_VDEVS);
	config.num_peers = __cpu_to_le32(TARGET_NUM_PEERS);
	config.num_offload_peers = __cpu_to_le32(TARGET_NUM_OFFLOAD_PEERS);

We are still using constants instead of ar->max_num_vdevs.

Was this done on purpose for some reason?

It will make my patches to support CT features a bit cleaner if we use the
values stored in ar->max_num_vdevs etc.


Ben Greear <greearb at>
Candela Technologies Inc

More information about the ath10k mailing list