[PATCH 1/2] ath10k: enable ANI by default

Kalle Valo kvalo at qca.qualcomm.com
Thu Mar 19 01:47:22 PDT 2015

Kalle Valo <kvalo at qca.qualcomm.com> writes:

> Ashok Raj Nagarajan <arnagara at qti.qualcomm.com> writes:
>> ANI is currently not enabled by default. Enable this feature by default.
>> Signed-off-by: Ashok Raj Nagarajan <arnagara at qti.qualcomm.com>
> You did not send this to ath10k list (and CC linux-wireless). Check the
> instructions here:
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches
> Also the commit log doesn't tell anything. What is ANI and why should it
> be enabled? What bug does this fix (if any)? How will the user see the
> difference after this patch is applied?
> As a rule of thumb, the commit log should tell any engineer (even one
> who is not familiar with ath10k) how the behaviour changes after the
> patch is applied. Think of your target group being distro maintainers,
> ath10k users, kernel subsystem maintainers etc. No company internal
> jargon or anything like that, write in plain english so that everyone
> understand.

I also forgot to CC ath10k list.

Kalle Valo

More information about the ath10k mailing list