[PATCH] ath10k: Remove trace about getting temperature

Kalle Valo kvalo at qca.qualcomm.com
Thu Mar 12 06:17:51 PDT 2015

Matthias Kaehlcke <mka at google.com> writes:

>     > -     ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
>     >       return skb;
>     I'm worried that this is dangerous, as that means that not all WMI
>     commands will be in debug and something might be missed because of that.
> I see your concern
>     Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or
>     adding a new log level?
> Switching to dynamic debugging (dev_dbg, ...) could be an option. Debug
> messages would be disabled by default but can be enabled at runtime

I don't really like dynamic debugging framework as it's not really
convenient with bigger drivers like ath10k. Is it possible to add
support for dynamic debugging without sacrificing the current debug
functionality, especially setting debug levels via debug_mask

Kalle Valo

More information about the ath10k mailing list