[PATCH] ath10k: remove unused variable 'id' in ath10k_pci_tx_pipe_cleanup()

Michal Kazior michal.kazior at tieto.com
Tue Jun 2 00:21:36 PDT 2015


On 2 June 2015 at 09:14, Raja Mani <rmani at qti.qualcomm.com> wrote:
> mete_data is extracted from ce descriptor and stored in variable 'id'.
> later, id is not used anywhere in the same function.
>
> Signed-off-by: Raja Mani <rmani at qti.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath10k/pci.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index 969a123..bbc349a 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -1275,7 +1275,6 @@ static void ath10k_pci_tx_pipe_cleanup(struct ath10k_pci_pipe *pci_pipe)
>         struct ath10k_ce_ring *ce_ring;
>         struct ce_desc *ce_desc;
>         struct sk_buff *skb;
> -       unsigned int id;
>         int i;
>
>         ar = pci_pipe->hif_ce_state;
> @@ -1299,8 +1298,6 @@ static void ath10k_pci_tx_pipe_cleanup(struct ath10k_pci_pipe *pci_pipe)
>                         continue;
>
>                 ce_ring->per_transfer_context[i] = NULL;
> -               id = MS(__le16_to_cpu(ce_desc[i].flags),
> -                       CE_DESC_FLAGS_META_DATA);
>
>                 ar_pci->msg_callbacks_current.tx_completion(ar, skb);

Good catch. I forgot to remove this. I guess one could say this qualifies as:

 Fixes: d84a512dca23 ("ath10k: remove transfer_id from
ath10k_hif_cb::tx_completion")


Michał



More information about the ath10k mailing list