[PATCH v2 2/7] ath10k: implement chanctx API

Johannes Berg johannes at sipsolutions.net
Fri Jan 30 05:10:46 PST 2015


On Fri, 2015-01-30 at 14:06 +0100, Michal Kazior wrote:

> I'm a bit reluctant to freely use mac80211 owned structures out of
> mac80211_ops callback context, i.e. from a tasklet fearing
> inconsistencies. Or am I worrying unnecessarily? If so I guess I'll
> redo this and use mac80211's structures directly :-)

Yeah that's a concern, we were just looking at something similar.
However, I think at least with channel contexts you should be fine since
mac80211 never really modifies them much, except for the width and # of
chains needed?

We've recently seen a similar issue with vif->bss_conf, and I'm
considering making that an RCU-protected pointer rather than the
embedded sub-struct, that way mac80211 can replace it atomically when
needed. I've yet to see if that's practical though.

johannes




More information about the ath10k mailing list