Clean up scan when start fails?

[Michal Kazior]

On 5 January 2015 at 20:04, Ben Greear <greearb at candelatech.com> wrote:
> Should we have something like this to clean up the scan
> state machine when firmware fails to start the scan?
>
> [greearb at ben-dt2 linux-3.19.dev.y]$ git diff
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index 6e4ece0..9020204 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -1057,6 +1057,7 @@ static int ath10k_wmi_event_scan(struct ath10k *ar, struct sk_buff *skb)
>                 break;
>         case WMI_SCAN_EVENT_START_FAILED:
>                 ath10k_warn(ar, "received scan start failure event\n");
> +               ath10k_wmi_event_scan_completed(ar);
>                 break;
>         case WMI_SCAN_EVENT_DEQUEUED:
>         case WMI_SCAN_EVENT_PREEMPTED:

Hmm.. I assume you still get the _START_FAILED sometimes?

In what state do you get it?

If you get it before _STARTED you'll hit a warning in
scan_completed(). It doesn't make sense to call it since all scan
users will fail to wait for ar->scan.started completion and clean up
anyway.

If you get it after _STARTED then I guess it does sense to clean up.


Michał