[PATCH 0/4] ath10k: implement fw stats for wmi-tlv

Michal Kazior michal.kazior at tieto.com
Sun Feb 15 23:08:28 PST 2015

On 15 February 2015 at 16:15, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>> There are some slight differences in fw stats
>> (sic) in wmi-tlv.
>> Firmware has changed the querying scheme and no
>> longer requires the ping-pong to get all stats.
>> The patchset doesn't change this behaviour so with
>> wmi-tlv it's possible to see the following
>> warnings when reading fw stats:
>>  ath10k_pci 0000:00:06.0: received unsolicited stats update event
>> The logic in ath10k still produces correct results
>> so this is harmless.
>> I wonder how to deal with this in a sane way. An
>> `if (op_ver == WMI_TLV)` is a little bad but
>> having a new ar->fw_feature flag just for a debug
>> facility like this is a bit silly. Or we can just
>> drop the warning and leave a comment. Ideas?
> I think we could just drop the warning and leave a comment. That
> shouldn't break anything, right?

We end up performing a few extra wmi exchanges but this is harmless.
Having an extra condition to handle this cleanly with wmi-tlv/qca6174
seems a bit of an overkill.

The warning was just an explicit way of specifying what we expected of
the fw stats exchange logic. The assertion is no longer valid so it
can go away.


More information about the ath10k mailing list