[PATCH v2] ath10k: Replace ioread with mb to drain write buffer

Jakub Kiciński moorray3 at wp.pl
Fri Feb 6 00:58:46 PST 2015

On Fri, 30 Jan 2015 16:14:30 -0800, Peter Oh wrote:
> Using ioread() to perform draining write buffer is excessive.
> Use compact API, mb(), that intended to be used for the case.
> It reduces total 14 CPU clocks per interrupt.
> Signed-off-by: Peter Oh <poh at qca.qualcomm.com>

I have no idea what the code does but this change looks suspicious. 
Usually the point of ioread() is to flush the interconnect buffers 
while mb() ensures ordering only from the CPU perspective.

Could you provide the reason *why* flushing buffers is unnecessary
in the commit message?

More information about the ath10k mailing list