[PATCH 0/4] ath10k: implement fw stats for wmi-tlv

Kalle Valo kvalo at qca.qualcomm.com
Wed Feb 4 00:49:55 PST 2015

Michal Kazior <michal.kazior at tieto.com> writes:

> There are some slight differences in fw stats
> (sic) in wmi-tlv.
> Firmware has changed the querying scheme and no
> longer requires the ping-pong to get all stats.
> The patchset doesn't change this behaviour so with
> wmi-tlv it's possible to see the following
> warnings when reading fw stats:
>  ath10k_pci 0000:00:06.0: received unsolicited stats update event
> The logic in ath10k still produces correct results
> so this is harmless.
> I wonder how to deal with this in a sane way. An
> `if (op_ver == WMI_TLV)` is a little bad but
> having a new ar->fw_feature flag just for a debug
> facility like this is a bit silly. Or we can just
> drop the warning and leave a comment. Ideas?

I think we could just remove the warning.

> Michal Kazior (4):
>   ath10k: add vdev stats processing
>   ath10k: change request stats command prototype
>   ath10k: add more wmi fw stat defines
>   ath10k: implement fw stats for wmi-tlv

There was a conflict in patch 2 but 3-way merge solved it automatically.
Please check the result in the pending branch.

Kalle Valo

More information about the ath10k mailing list