Bugs in wake-queue logic.

[Janusz Dziedzic]

On 4 December 2015 at 07:30, Ben Greear <greearb at candelatech.com> wrote:
>
>
> On 12/03/2015 10:11 PM, Janusz Dziedzic wrote:
>>
>> On 4 December 2015 at 07:06, Janusz Dziedzic <janusz.dziedzic at tieto.com>
>> wrote:
>>>
>>> On 3 December 2015 at 20:52, Ben Greear <greearb at candelatech.com> wrote:
>>>>
>>>> So, after tweaking a firmware image to actually be able to use
>>>> all tx-buffers, then queues can actually be stopped on the host
>>>> now.
>>>>
>>>> I'm now getting splats related to tx-queue being
>>>> out of range.
>>>>
>>>> Why are we using vdev_id as the queue-id below?
>>>>
>>> This is comment in the code:
>>>
>>>          /* Using vdev_id as queue number will make it very easy to do
>>> per-vif
>>>           * tx queue locking. This shouldn't wrap due to interface
>>> combinations
>>>           * but do a modulo for correctness sake and prevent using
>>> offchannel tx
>>>           * queues for regular vif tx.
>>>           */
>>>
>> BTW, I think Michal will send soon "new" design for that because of
>> MU-MIMO implementation.
>
>
> It would be nice if ath10k could gracefully deal with 64 vdevs using only
> the default 16 maximum tx-queues supported by mac80211.
>
I think Michal changed also mac80211 (netdev) queues - that can be
used/locked per station for MU-MIMO case.
I think he will send paches soon, while now he stuck in Chennai do to
flooding ...

BR
Janusz

> I wrote a patch that extended max-queues to 65, but not sure it will
> make it upstream...
>
>
> Thanks,
> Ben
>
> --
> Ben Greear <greearb at candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com