[RFC PATCH 3/3] ath10k: add cal_data debugfs file

Kalle Valo kvalo at qca.qualcomm.com
Fri Sep 12 03:50:30 PDT 2014

Michal Kazior <michal.kazior at tieto.com> writes:

> On 11 September 2014 22:31, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> Provide calibration data used by the firmware to user space via a debugfs file.
>> This makes it easier to debug calibration related problems.
>> Example:
>> sudo cp /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data 1.cal
> How about having a generic r/w access to target memory via debugfs?
> Userspace would deal with the extraction of the cal data. 

Yeah, Yanbo is working on that kind of generic interface.

> Or do you want to make it easier for the user to provide the cal data
> without any extra tools (and that sending entire unprocessed target
> memory dump may introduce some privacy concerns)?

This (to make it easier) is exactly my motivation here. In some of the
problems, especially once we add support to get calibration data from
host instead of just OTP, it's important to get easily access to the
calibration data. User only needs to do a simple cp operation and send
the file to us for further investigation.

Of course we could use the generic target memory interface for this, but
it's just more complicated for an unexperienced user and that's why I
think we should have this interface. But to be honest I'm not 100% sure
yet so other comments are more than welcome.

Kalle Valo

More information about the ath10k mailing list