[PATCH v3] ath10k: fix debugfs_create_dir() checking

Kalle Valo kvalo at qca.qualcomm.com
Wed Sep 10 09:14:37 PDT 2014

Michal Kazior <michal.kazior at tieto.com> writes:

> The function may return an -ENODEV if debugfs is
> disabled in kernel. This should originally be
> guarded by ath10k's Kconfig but it still makes
> sense to check for the non-NULL errno return
> value.


> Reported-by: Matteo Croce <matteo at openwrt.org>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
> ---
> Notes:
>     v2:
>      * fix commit subject (sorry for the noise!)
>     v3:
>      * remove Kconfig patch (I accidentally amended something I shouldn't have,
>        sorry for the noise again! I guess I need a break..)
> @Kalle:
>  - this patch prevents kernel oops but ath10k will
>    fail to load
>  - Matteo's patch prevents kernel oops and ath10k
>    will load fine
> Since mine is just an extra precaution feel free
> to drop all but the first paragraph of my commit
> message if you want to.

Thanks, I just left the first paragraph like you recommended. Also I had
a conflict with this patch, please double check my resolution in


Kalle Valo

More information about the ath10k mailing list