[PATCH 2/3] ath10k: expose hw restart via debugfs

Michal Kazior michal.kazior at tieto.com
Mon Oct 13 01:45:18 PDT 2014


On 13 October 2014 10:07, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
[...]
>> --- a/drivers/net/wireless/ath/ath10k/debug.c
>> +++ b/drivers/net/wireless/ath/ath10k/debug.c
>> @@ -694,7 +694,8 @@ static ssize_t ath10k_read_simulate_fw_crash(struct file *file,
>>               "To simulate firmware crash write one of the keywords to this file:\n"
>>               "`soft` - this will send WMI_FORCE_FW_HANG_ASSERT to firmware if FW supports that command.\n"
>>               "`hard` - this will send to firmware command with illegal parameters causing firmware crash.\n"
>> -             "`assert` - this will send special illegal parameter to firmware to cause assert failure and crash.\n";
>> +             "`assert` - this will send special illegal parameter to firmware to cause assert failure and crash.\n"
>> +             "`request` - this will simply queue hw restart without fw/hw actually crashing.\n";
>
> "request" is not really very descriptive command. Maybe call it
> "hw-restart" because that's what it really does, right?

Good idea. I'll rename it.


Michał



More information about the ath10k mailing list