[PATCH v2] ath10k: fix kernel panic while shutting down AP

Kalle Valo kvalo at qca.qualcomm.com
Sun Oct 12 10:59:15 PDT 2014


Rajkumar Manoharan <rmanohar at qti.qualcomm.com> writes:

> Based on GFP flag given to DMA coherent allocation, the behaviour of
> dma_free_coherent is changed. This behavioural diffrence is noticeable
> in ARM platform. If DMA memory is allocated with GFP_KERNEL, free
> coherent can not be called inside spin lock. This is causing kernel
> crash in ARM platforms. Fix this by changing GFP flag to atomic.
>
> Cc: Michal Kazior <michal.kazior at tieto.com>
> Signed-off-by: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>

Thanks, applied.

I modified the commit log a bit to mention the possible commit causing
this:

commit 82d7aba71541a308bc19e869f7cf7423672dee37
Author: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
Date:   Fri Oct 10 17:38:27 2014 +0530

    ath10k: fix kernel panic while shutting down AP
    
    Based on GFP flag given to DMA coherent allocation, the behaviour of
    dma_free_coherent is changed. This behavioural diffrence is noticeable
    in ARM platform. If DMA memory is allocated with GFP_KERNEL, free
    coherent can not be called inside spin lock. This is causing kernel
    crash in ARM platforms. Fix this by changing GFP flag to atomic.
    
    This is most likely a regression from commit 64badcb6d645 ("ath10k: workaround
    fw beaconing bug").
    
    Cc: Michal Kazior <michal.kazior at tieto.com>
    Signed-off-by: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>


-- 
Kalle Valo



More information about the ath10k mailing list