[RFC] ath10k: Fix shared WEP

Michal Kazior michal.kazior at tieto.com
Fri Nov 21 02:14:03 PST 2014

On 21 November 2014 10:54, Sujith Manoharan <sujith at msujith.org> wrote:
> Michal Kazior wrote:
>> Read access to peer->keys should be protected by either data_lock or
>> conf_mutex. Obviously the latter can't be used because this function
>> will be called from an atomic context leaving the data_lock. The
>> entire is_peer_wep_key_set() should require data_lock to be held while
>> it is called to avoid races.
>> Oh, and apparently this is buggy anyway because
>> ath10k_install_peer_wep_keys() is oblivious to this. Oops..
> I don't think it can happen, though ? ath10k_install_peer_wep_keys()
> would be called only when a station transitions to ASSOC and message 3
> can't be received when that happens ?

Good point, but what I'm worried it'll be easier to miss this subtlety
and introduce races in the future.

> (But, I did see a lockdep splat when using WEP).

Do you have it saved somewhere? If so, can you post it, please?


More information about the ath10k mailing list