Protected flag is clear in Monitor Mode

[Michal Kazior]

On 19 May 2014 12:43, Yeoh Chun-Yeow <yeohchunyeow at gmail.com> wrote:
> On Mon, May 19, 2014 at 5:25 PM, Michal Kazior <michal.kazior at tieto.com> wrote:
>> On 16 May 2014 06:38, Yeoh Chun-Yeow <yeohchunyeow at gmail.com> wrote:
>>> Hi, all
>>>
>>> I try to use ath10k (firmware version 10.1.467.2-1_ as standalone
>>> monitor mode. I assume that monitor mode will allows the frame to pass
>>> to upper layer without any modification.
>>>
>>> But it seems that the protected flag in frame control is clear while I
>>> capture with wireshark. I has verified that the ath9k has not such
>>> issue and the protected flag is set.
>>>
>>> So is this a known issue in monitor mode for ath10k?
>>
>> Good catch!
>>
>> ath10k doesn't really check if frame was decrypted by firmware or not
>> (there's no explicit descriptor flag for that).
>>
>> I think we need to rely on the raw frame decap mode as an implicit
>> indication a frame must not have it's protected flag stripped.
>>
>
> I try to set TARGET_10X_RX_DECAP_MODE to ATH10K_HW_TXRX_RAW. But still
> not working.
>
> So we need firmware change for this?

There's absolutely no need to *set* the rx decap mode to raw.

What I meant was to look at decap mode in htt rx descriptor of each
frame when deciding whether to strip the protected flag or not. I've
made a patch but I need to test a few things before sending it out.


Michał