[RFTv2 4/5] ath10k: wait for mgmt tx when flushing too

Kalle Valo kvalo at qca.qualcomm.com
Thu May 15 03:26:47 PDT 2014


Michal Kazior <michal.kazior at tieto.com> writes:

> In the meantime if you want to hasten tx queue ps expiration you can
> try to set `ap_detect_out_of_sync_sleeping_sta_time_secs` vdev param
> to 1 second (default is 10 set in firmware if I'm not mistaken). I
> haven't tested it but this should in theory shorten tx credit
> starvation duration and avoid cascade of wmi timeouts (wmi timeout=3
> seconds, max mgmt tx pending=2 x 1 second each=2s worst case) as well
> as should prevent tx flushing from failing (timeout=5). This will not
> prevent from beacon SWBA overruns because tx starvation is still
> possible although it should be faster to recover.
>
> I wonder if it's reasonable to set this vdev param explicitly in
> upstream driver. We should probably consider longest beacon interval
> in effect when calculation the value to set. Thoughts, anyone?

I haven't looked at the details yet but I think that would be a good
idea. Are there any downsides from doing that change?

-- 
Kalle Valo



More information about the ath10k mailing list