[PATCH v2 2/2] ath10k: support get/set antenna configurations.

Kalle Valo kvalo at qca.qualcomm.com
Tue May 13 10:50:14 PDT 2014


Ben Greear <greearb at candelatech.com> writes:

> On 05/12/2014 08:43 AM, Vu Hai NGUYEN wrote:
>> Thank you very much for the patch, I just had a question of a new bie: Your patch is for the branch of ath-next-test, not for the branch ath-master, right?
>> But even it is for ath-next-test, I can not apply it, there is a conflict, for example the first change of your patch (in file "core.h" which starts from line 472 but I found in the branch of ath-next-test that it must start from line 444 where there is u32 dfs_block_radar_events; )
>> So I have to apply your patch manually (I look for the different and add it to the code) and then the result is quite good, I can see the Available and Configured Antennas from "iw list". Then I can also select the antenna thanks to the command "iw phyX set antenna" too. 
>> Sorry if I disturbing you for the question about applying the patch. 
>
> My patch was against my own tree which is a mix of 3.14 and an older
> version of git://github.com/kvalo/ath.git
>
> I do not have time right now to re-do the patch, but next time I get
> some time I will fix the patch to apply to ath.git. If someone else
> wants to do it first, I will not complain :)

If you send patches agains some out-of-tree version of ath10k, PLEASE
state that clearly. I now wasted time trying to apply the patch, before
I read your reply.

The best (=easiest for me) is to base patches on master branch of my
ath.git tree.

-- 
Kalle Valo



More information about the ath10k mailing list