[RFC 1/4] ath10k: provide firmware crash info via debugfs.

Ben Greear greearb at candelatech.com
Wed Jun 4 10:11:22 PDT 2014


On 06/04/2014 02:04 AM, Michal Kazior wrote:

>> +               if (dbufp == dbg_hdr.dbuf) {
>> +                       /* It is a circular buffer it seems, bail if next
>> +                        * is head
>> +                        */
> 
> Hmm, we seem to be mixing comment styles in ath10k now I guess (this
> applies to other instances of multi-line comments in your patch). What
> multi-line comment style should we really be using in ath10k? Kalle?

Check-patch bitches if you do it differently than what is above, so I say
we keep it as I have it.  Not worth cleaning up other comments to match
unless someone actually cares enough to do it...

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com




More information about the ath10k mailing list