[RFC 2/4] ath10k: save firmware debug log messages.

Joe Perches joe at perches.com
Tue Jun 3 09:45:44 PDT 2014


On Tue, 2014-06-03 at 09:25 -0700, greearb at candelatech.com wrote:
> They may be dumped through the firmware dump debugfs
> file.
[]
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
[]
> @@ -1084,11 +1084,14 @@ static void ath10k_wmi_event_echo(struct ath10k *ar, struct sk_buff *skb)
>  
>  static int ath10k_wmi_event_debug_mesg(struct ath10k *ar, struct sk_buff *skb)
>  {
> +	u32 *m = (u32 *)(skb->data);
>  	ath10k_dbg(ATH10K_DBG_WMI, "wmi event debug mesg len %d\n",
>  		   skb->len);
>  
>  	trace_ath10k_wmi_dbglog(skb->data, skb->len);
>  
> +	ath10k_dbg_save_fw_dbg_buffer(ar, (u8 *)(&(m[1])), skb->len - 4);
> +
>  	return 0;
>  }
>  

That last line looks an overly complicated way of writing

	ath10k_dbg_save_fw_dbg_buffer(ar, skb->data + 4, skb->len - 4);

btw: why skip the first 4 bytes?





More information about the ath10k mailing list