[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

Dave Airlie airlied at gmail.com
Fri Jul 18 14:14:12 PDT 2014


>
> We have almost 1000 more uses of the non-macro version than the "macro"
> version in the kernel today:
> $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
> 262
> $ git grep "const struct pci_device_id" | wc -l
> 1254

did you check for non-const ones? just to see if we have any of the
broken case in the tree :-)

as for consistency, pci_dev vs usb_device :-P

Dave.



More information about the ath10k mailing list