[RFT/RFC 0/5] ath10k: handle/report A-MSDU as a skb list

[Janusz Dziedzic]

On 18 July 2014 14:32, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic at tieto.com> writes:
>
>> This is prototype, how we can handle A-MSDU as a skb list in mac80211.
>> No changes in mac80211 reordering code required in such case, also we
>> don't need to build one big frame using memcpy ...
>>
>> With such prototype tid_agg_rx->reorder_buf[sn] will describe exactly
>> one MPDU (with included A-MSDU subframes if skb->next) and detection of
>> duplicated frames will work correctly. So, reordering should works
>> correctly.
>>
>> I tested this with A-MPDU and A-MSDU run together (A-MSDU frame up to
>> 10k) - TCP STA -> AP. I used ath10k STA with unlocked A-MSDU limit in
>> RC in firmware. Didn't notice any problems.
>
> So what are you exactly fixing here? It would be nice to get some
> background and motivations for the changes in the cover letter.
>
> Also we have so many reordering patches that I'm confused now. For
> example, how is this related to patch "ath10k: handle attention flags
> correctly when A-MSDU"?
>
We should skip this patchset, while we decide to change reordering
code in mac80211 instead of passing skb list.

ath10k: handle attention flags correctly when A-MSDU  is required
while fix generic FCS reporting issue.

BR
Janusz