[PATCH] ath10k: use VHT phymodes for 20/40MHz channels

Kalle Valo kvalo at qca.qualcomm.com
Fri Jan 17 07:31:27 EST 2014


Bartosz Markowski <bartosz.markowski at tieto.com> writes:

> chandef does not provide 11n / 11ac split. Use the highest
> phymodes for 20/40MHz channels, firmware can operate on.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski at tieto.com>

Is this just code cleanup and or does this actually fix something?

> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef)
>  			phymode = MODE_11A;
>  			break;
>  		case NL80211_CHAN_WIDTH_20:
> -			phymode = MODE_11NA_HT20;
> +			phymode = MODE_11AC_VHT20;
>  			break;
>  		case NL80211_CHAN_WIDTH_40:
> -			phymode = MODE_11NA_HT40;
> +			phymode = MODE_11AC_VHT40;
>  			break;
>  		case NL80211_CHAN_WIDTH_80:
>  			phymode = MODE_11AC_VHT80;

But doesn't this mean that we will use, for example, MODE_11AC_VHT20 on
11n mode? I think we need to investigate how MODE_11AC_VHT20 and
MODE_11NA_HT20 actually differ (and the same for 40 MHz channels).

-- 
Kalle Valo



More information about the ath10k mailing list