[RFC/RFT 1/7] ath10k: remove DMA mapping wrappers

Kalle Valo kvalo at qca.qualcomm.com
Wed Feb 19 07:37:57 EST 2014


Michal Kazior <michal.kazior at tieto.com> writes:

> There's no real benefit from using them. DMA-API
> already provides debugging. Some skbuffs are
> already mapped directly with DMA-API since wrapper
> arguments were insufficient and extending them
> would be pointless.
>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -1360,7 +1360,7 @@ static void ath10k_wmi_event_host_swba(struct ath10k *ar, struct sk_buff *skb)
>  	struct wmi_bcn_info *bcn_info;
>  	struct ath10k_vif *arvif;
>  	struct sk_buff *bcn;
> -	int vdev_id = 0;
> +	int err, vdev_id = 0;

We use ret, res and err as names for the status variable. We should try
to unify this and use ret everywhere.

-- 
Kalle Valo



More information about the ath10k mailing list