[PATCH v2 7/7] ath10k: implement wmi-tlv backend

Kalle Valo kvalo at qca.qualcomm.com
Mon Dec 1 06:19:23 PST 2014


Michal Kazior <michal.kazior at tieto.com> writes:

> On 27 November 2014 at 10:11, Michal Kazior <michal.kazior at tieto.com> wrote:
>> Latest main firmware branch introduced a new WMI
>> ABI called wmi-tlv. It is not a tlv strictly
>> speaking but something that resembles it because
>> it is ordered and may have duplicate id entries.
>>
>> This prepares ath10k to support new hw.
>>
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
> [...]
>> @@ -215,6 +254,42 @@ static inline char *wmi_service_name(int service_id)
>>         SVCSTR(WMI_SERVICE_BURST);
>>         SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT);
>>         SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT);
>> +       SVCSTR(WMI_SERVICE_ROAM_SCAN_OFFLOAD);
>> +       SVCSTR(WMI_SERVICE_AP_PS_DETECT_OUT_OF_SYNC);
>> +       SVCSTR(WMI_SERVICE_EARLY_RX);
> [...]
>> +       SVCSTR(WMI_SERVICE_RX_FULL_REORDER);
>> +       SVCSTR(WMI_SERVICE_DHCP_OFFLOAD);
>
> I've added 3 new service enums in v2:
> WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT, WMI_SERVICE_MDNS_OFFLOAD,
> WMI_SERVICE_SAP_AUTH_OFFLOAD but apparently I forgot to add SVCSTR()
> for that..

I added those in my not-yet-submitted v3:

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index a31a3028a847..7d091a74d3f3 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -290,6 +290,9 @@ static inline char *wmi_service_name(int service_id)
        SVCSTR(WMI_SERVICE_ROAM_HO_OFFLOAD);
        SVCSTR(WMI_SERVICE_RX_FULL_REORDER);
        SVCSTR(WMI_SERVICE_DHCP_OFFLOAD);
+       SVCSTR(WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT);
+       SVCSTR(WMI_SERVICE_MDNS_OFFLOAD);
+       SVCSTR(WMI_SERVICE_SAP_AUTH_OFFLOAD);
        default:
                return NULL;
        }


-- 
Kalle Valo



More information about the ath10k mailing list