[PATCH v2 2/2] ath10k: add testmode

[Arend van Spriel]

On 08/29/14 08:03, Kalle Valo wrote:
> Arend van Spriel<arend at broadcom.com>  writes:
>
>> On 08/28/14 10:02, Kalle Valo wrote:
>>> Kalle Valo<kvalo at qca.qualcomm.com>   writes:
>>
>>> Johannes suggested to put this to a separate file as that way it's
>>> easier for the user space. In v3 I'm planning to create testmode_uapi.h
>>> for this.
>>
>> I suppose that file will/should end up in include/uapi/...
>
> I was thinking not to put this to the include directory. This is just a
> testmode interface used only by few people, not a proper driver
> interface.

I see. In that case I would avoid the term 'uapi'. I think it will 
impose certain expectations.

>> so wouldn't it be better to call it ath10k_testmode.h?
>
> We already have testmode.h so having ath10k_testmode.h in the same
> directory would be confusing. Would testmode_i.h be any better?

What does it contain? Looks like command and attribute definitions for 
your testmode support. Maybe testmode_defs.h? As long as it is not uapi.

Regards,
Arend