[ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178
michal.kazior at tieto.com
Tue Aug 26 02:15:20 PDT 2014
On 26 August 2014 11:05, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> + ath10k at lists.infradead.org
> Julia Lawall <julia.lawall at lip6.fr> writes:
>> On Tue, 26 Aug 2014, kbuild test robot wrote:
>>> tree: git://github.com/kvalo/ath ath-next-test
>>> head: 077256daf111b4db074ac602bed1e96e95e3a4a4
>>> commit: 6b7b27b12f4af628305940c1c083b8558d7618ac [47/51] ath10k: improve logging to include dev id
>>> :::::: branch date: 16 hours ago
>>> :::::: commit date: 16 hours ago
>>> >> drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178
>>> Please consider folding the attached diff :-)
>> The variable is indeed not needed. I guess the function returns a value
>> for parallelism with ath10k_err. But the function dev_err used in that
>> function returns a value, while the macro dev_warn_ratelimited used in
>> this function does not.
> Ok. If it's ok for Michal I'll fold the patch before I commit it.
I'm okay with that. Thanks.
More information about the ath10k