[PATCH v7 2/8] ath10k: provide firmware crash info via debugfs

Kalle Valo kvalo at qca.qualcomm.com
Wed Aug 20 00:29:27 PDT 2014

Ben Greear <greearb at candelatech.com> writes:

>>> +       /* Gather dbg-log */
>>> +       dump_tlv = (struct ath10k_tlv_dump_data *)(buf + sofar);
>>> +       dump_tlv->type = cpu_to_le32(ATH10K_FW_CRASH_DUMP_DBGLOG);
>>> +       dump_tlv->tlv_len = cpu_to_le32(sizeof(crash_data->dbglog_entry_data));
>> Hmm should this really be sizeof()? Not next_idx (which effectively
>> defines number of bytes of the dbglog)?
> I haven't tried decoding this yet, but we may need to know the next_idx
> to decode this properly.

I really don't like the idea of having untested code in ath10k. Buggy
code is okay (preferably document the known bugs when submitting code),
but untested code is not.

Kalle Valo

More information about the ath10k mailing list