[PATCH 4/5] ath10k: split ce irq/handler setup
michal.kazior at tieto.com
Tue Aug 19 05:30:39 PDT 2014
On 14 August 2014 10:40, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>> It doesn't make much sense to overwrite send_cb
>> and recv_cb callbacks over and over again whenever
>> transport starts. Just make sure to unmask copy
>> engine interrupts when starting.
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
> The patch looks, just a followup question for the future:
>> @@ -1674,7 +1639,9 @@ static int ath10k_pci_ce_init(struct ath10k *ar)
>> pipe_info->hif_ce_state = ar;
>> attr = &host_ce_config_wlan[pipe_num];
>> - ret = ath10k_ce_init_pipe(ar, pipe_num, attr);
>> + ret = ath10k_ce_init_pipe(ar, pipe_num, attr,
>> + ath10k_pci_ce_send_done,
>> + ath10k_pci_ce_recv_data);
> As we call ath10k_ce_init_pipe() only once and seem to have only one set
> of functions, why even bother bother with function pointers? What if we
> just call the functions directly?
Yeah, we can remove this abstraction later. I don't there's anything
depending on it anymore.
More information about the ath10k