[PATCH 6/6] ath10k: move fw init print

Kalle Valo kvalo at qca.qualcomm.com
Thu Aug 14 01:27:29 PDT 2014

Kalle Valo <kvalo at qca.qualcomm.com> writes:

> Michal Kazior <michal.kazior at tieto.com> writes:
>> Firmware probing is done only once when driver is
>> registered and firmware version is guaranteed to
>> remain the same until driver is unregistered.
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
> [...]
>> -	__set_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags);
> Doesn't this break this print in pci.c:
>         if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags))
>            ath10k_info("pci irq %s irq_mode %d reset_mode %d\n",
>                                     irq_mode, ath10k_pci_irq_mode,
>                                                     ath10k_pci_reset_mode);

Ah, now I understand. You rework that part in patch "ath10k: setup irq
method in probe" which was just in a different patchset. Then this extra
print during interface up is ok, as it just happens between the two

Kalle Valo

More information about the ath10k mailing list