[PATCH 2/6] ath10k: remove target soc ps code

Kalle Valo kvalo at qca.qualcomm.com
Fri Aug 8 03:45:31 PDT 2014

Michal Kazior <michal.kazior at tieto.com> writes:

> The soc powersave was disabled by default. It
> never was fully tested. Some hw apparently had
> problems with it and the implementation itself had
> a possible race.
> Just remove the refcounting and simply wake up the
> device when probing and put to sleep when
> removing.
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

This one introduced new warnings:

drivers/net/wireless/ath/ath10k/pci.c:646:5: warning: symbol 'ath10k_pci_wake' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/pci.c:653:6: warning: symbol 'ath10k_pci_sleep' was not declared. Should it be static?

Is it okay if I fix it like this:

--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -643,14 +643,14 @@ static int ath10k_pci_wake_wait(struct ath10k *ar)
        return -ETIMEDOUT;
-int ath10k_pci_wake(struct ath10k *ar)
+static int ath10k_pci_wake(struct ath10k *ar)
        ath10k_pci_reg_write32(ar, PCIE_SOC_WAKE_ADDRESS,
        return ath10k_pci_wake_wait(ar);
-void ath10k_pci_sleep(struct ath10k *ar)
+static void ath10k_pci_sleep(struct ath10k *ar)
        ath10k_pci_reg_write32(ar, PCIE_SOC_WAKE_ADDRESS,

Kalle Valo

More information about the ath10k mailing list