[PATCH] ath10k: fix wmi service bitmap debug

Kalle Valo kvalo at qca.qualcomm.com
Fri Aug 1 23:39:33 PDT 2014


Michal Kazior <michal.kazior at tieto.com> writes:

> The 10.x and main firmware branches have
> conflicting WMI service bitmap definitions.
>
> This also fixes WMI services parsing on big-endian
> hosts and changes debugfs output to be more human
> friendly.
>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

[...]

> +	SVCSTR(WMI_SERVICE_TX_ENCAP)
> +	SVCSTR(WMI_SERVICE_BURST)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT)
>  	default:
> -		return "UNKNOWN SERVICE\n";
> +		return NULL;

This introduces a new checkpatch warning:

drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE)

But I think that's just a false warning and I should ignore it. Any
other ideas?

-- 
Kalle Valo



More information about the ath10k mailing list