[PATCH] ath10k: Fix un-initialized debug objects.

Ben Greear greearb at candelatech.com
Fri Oct 25 10:59:46 EDT 2013

On 10/25/2013 12:49 AM, Kalle Valo wrote:
> greearb at candelatech.com writes:

>>   	INIT_WORK(&ar->restart_work, ath10k_core_restart);
>> +	ath10k_debug_init(ar);
> For symmetry would it make more sense to move ath10k_debug_destroy() to
> ath10k_core_unregister()? That way we could avoid adding a new function.

In my opinion, you should initialize such things as early as possible
so you don't have to worry so much about the various error cases leaving
things un-initialized.  I believe my patch accomplished that.

What new function are you planning to avoid?


Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

More information about the ath10k mailing list