[PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN

Eric Dumazet eric.dumazet at gmail.com
Thu Oct 3 00:44:38 EDT 2013


On Thu, 2013-10-03 at 07:34 +0300, Kalle Valo wrote:

> Do you mean '6' or the union? The 6 can replaced with ETH_ALEN AFAICS.
> But the union is needed for aligning the packets as firmware expects
> them.

I mean the 6, of course, since Joe seems to actively track them, as if
ETH_ALEN could change eventually, you never know.

I am worrying this will take another hundred patches ...

Regarding this union, the __packed attributes seem overkill, no ???





More information about the ath10k mailing list