[PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN

Luis R. Rodriguez mcgrof at do-not-panic.com
Wed Oct 2 13:44:32 EDT 2013

On Tue, Oct 1, 2013 at 11:40 PM, Joe Perches <joe at perches.com> wrote:
> Please include netdev.  (cc'd)
>> Joe Perches <joe at perches.com> writes:
>> > Convert the memset/memcpy uses of 6 to ETH_ALEN
>> > where appropriate.
>> > Signed-off-by: Joe Perches <joe at perches.com>

I think these sorts of patches are good -- but once applied it'd be
good if we can get the SmPL grammar expressed for it and then have
developers / maintainers regularly doing:

make coccicheck MODE=patch M=path > path-cocci.patch

Unfortunately right now MODE=patch takes about 3 1/2 minutes for
ath9k, MODE=org takes ~10 minutes for ath9k (17 minutes for all of
ath/), and MODE=context takes ~8 minutes on ath9k -- I do believe its
a bit unreasonable to expect patch submitters to use this, but
certainly great practice. Some of the time differences on the reports
can be explained by the fact that some SmPL will only be used for some

Even though it takes a while right now it'd be great practice to use
coccicheck to prevent these type of changes from going in again,
things that checkpatch.pl won't be able to catch.


More information about the ath10k mailing list