[PATCH 2/2] ath10k: fix scheduling while atomic bug

Kalle Valo kvalo at qca.qualcomm.com
Tue Oct 1 12:35:45 EDT 2013

Michal Kazior <michal.kazior at tieto.com> writes:

> Recent WMI/HTC changes broke WEP with multiple
> keys. If WMI had no HTC TX credits to submit
> command for default wep index update it would
> trigger a bug.
> This simply moves the wep key index update to a
> worker.
> The key update may happen some time after first
> frame with a different wep key has been sent (i.e.
> some frames will be sent with old key). This was
> the case before too as WMI commands were
> asynchronous.
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

This looks problematic. Basically you just delay sending the WMI
command, but there's no guarantee that we actually have free credits at
the time of transmission. So to me it looks like this fixes the issue
just by luck.

Kalle Valo

More information about the ath10k mailing list