[PATCH 1/3] ath10k: add phyerr/dfs handling

Kalle Valo kvalo at qca.qualcomm.com
Wed Nov 13 03:59:27 EST 2013

Kalle Valo <kvalo at qca.qualcomm.com> writes:

>> I think we can use here spin_lock_bh(&ar->data_lock) when setting
>> ar->debug.dfs_stats and when reading this from debugfs.
>> But, is that really needed (in worst case we will get older values via debugfs)?
> I would prefer not to have any race conditions in the driver, even if
> it's just statistics. If there's only a race with statistics atomic
> variables are also one option.

I took a new look at these statistics and I think you are right. It
feels a bit overkill to use locking or atomic variables here.

Kalle Valo

More information about the ath10k mailing list