[PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.

Kalle Valo kvalo at qca.qualcomm.com
Mon Nov 11 04:14:44 EST 2013

Ben Greear <greearb at candelatech.com> writes:

> On 11/08/2013 01:58 AM, Kalle Valo wrote:
>> greearb at candelatech.com writes:
>>> From: Ben Greear <greearb at candelatech.com>
>> I did some changes to this patch:
>> https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
>> The patch is still on ath-next-test branch. Please take a look and if
>> it's ok for you, send you S-o-b tag so that I can apply it (it was
>> missing).
> This part has some grammar issues, it seems to say that the failure
> is due to changed bssid.  Maybe make it instead:
> Failed to add peer %pM for vdev %d when changing bssid, error: %i
> -        ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
> -              info->bssid, arvif->vdev_id);
> +        ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
> +              info->bssid, arvif->vdev_id, ret);
> Either way, it's better than what was there before, so:
> Signed-off-by: Ben Greear <greearb at candelatech.com>

Good point, thanks. I just didn't use the word error as I thought that
wasn't necessary. New version which I'll apply soon:


Kalle Valo

More information about the ath10k mailing list