[PATCH 1/3] ath10k: prevent HTC from being used after stopping

Michal Kazior michal.kazior at tieto.com
Fri Jul 19 07:08:12 EDT 2013


On 19 July 2013 13:04, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>
>> It was possible to submit new HTC commands
>> after/while HTC stopped. This led to memory
>> corruption in some rare cases.
>>
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
>
> [...]
>
>> @@ -957,7 +955,6 @@ void ath10k_htc_stop(struct ath10k_htc *htc)
>>       }
>>
>>       ath10k_hif_stop(htc->ar);
>> -     ath10k_htc_reset_endpoint_states(htc);
>>  }
>
> Is this on purpose? I can't fit it to the description.

You're right. I should've mentioned that in the commit message.

This line is simply unnecessary. Do you prefer fixing the commit
message accordingly or should I post it as a separate patch?


Pozdrawiam / Best regards,
Michał Kazior.



More information about the ath10k mailing list