drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is always true due to limited range of data type

[Kalle Valo]

Hi Fengguang,

Fengguang Wu <fengguang.wu at intel.com> writes:

> FYI, there are new compile warnings show up in
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   6d128e1e72bf082542e85f72e6b7ddd704193588
> commit: 5e3dd157d7e70f0e3cea3f2573ed69fb156a19d5 ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices
> date:   4 weeks ago
> config: make ARCH=avr32 allyesconfig
>
> All warnings:
>
>    In file included from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined

This doesn't look like fault of ath10k.

>    In file included from arch/avr32/include/asm/param.h:4,
>                     from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/uapi/asm/param.h:6:1: warning: this is the location of the previous definition
>    drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_check_fw_version':
>>> drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is
always true due to limited range of data type

Geert already reported this, I'll fix it.

>    In file included from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined

Same as the first warning.

-- 
Kalle Valo