[PATCH] ath10k: implement per-VDEV FW statistics

Kalle Valo kvalo at qca.qualcomm.com
Wed Aug 28 06:15:45 EDT 2013


Bartosz Markowski <bartosz.markowski at tieto.com> writes:

> The WMI_REQUEST_PEER_STAT command with latst (1.0.0.716) FW
> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>
> This is a backward compatible change. In case of older FW the VDEV
> statistics are simply not returned.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski at tieto.com>

[...]

>  		for (i = 0; i < num_peer_stats; i++) {
> -			peer_stats = (struct wmi_peer_stats *)tmp;
> +			peer_stats = (struct wmi_peer_stats_1 *)tmp;

Oh yeah, you assume here that _v2 struct starts with _v1. That's a bit
dangerous, at least add a comment here saying that.

-- 
Kalle Valo



More information about the ath10k mailing list